fix(lint): don't use deny(warnings) in library, rather use it in ci.

simonsan commented 3 months ago

It is already being set in CI, so otherwise no changes needed.

https://www.reddit.com/r/rust/comments/f5xpib/psa_denywarnings_is_actively_harmful/

https://rust-unofficial.github.io/patterns/anti_patterns/deny-warnings.html

slawlor commented 3 months ago

I'm fine with this if you also add the rustc flags to the CI

runs-on: ubuntu-latest
env:
      RUSTFLAGS: -D warnings

simonsan commented 3 months ago

Please add CI flags

https://github.com/slawlor/ractor/blob/main/.github/workflows/ci.yaml#L67

The appropriate flags are already added, It seems.

slawlor commented 3 months ago

Ah I was looking at the flags on build but yes clippy will gate the ci well enough. Approving

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.47%. Comparing base (8c310e7) to head (9f106da). Report is 12 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #218 +/- ## ========================================== + Coverage 79.73% 81.47% +1.73% ========================================== Files 50 50 Lines 9790 9483 -307 ========================================== - Hits 7806 7726 -80 + Misses 1984 1757 -227 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

slawlor / ractor

fix(lint): don't use deny(warnings) in library, rather use it in ci. #218

Codecov Report