search

slawlor / ractor

Rust actor framework
MIT License
1.52k stars 73 forks source link

Adding tests for queueing and fix bug in queue length calculation #270

Closed slawlor closed 1 month ago

slawlor commented 1 month ago

We were calculating the number of removed queue items in reverse leading to an underflow on a usize.

Also added test coverage on queueing implementations.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 90.19608% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.43%. Comparing base (6a5ac82) to head (cb49674).

Files with missing lines Patch % Lines
ractor/src/factory/queues.rs 90.19% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #270 +/- ## ========================================== + Coverage 79.98% 80.43% +0.45% ========================================== Files 60 60 Lines 10287 10388 +101 ========================================== + Hits 8228 8356 +128 + Misses 2059 2032 -27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.