search

slawlor / ractor

Rust actor framework
MIT License
1.52k stars 73 forks source link

tokio version specification is outdated in ractor/Cargo.toml #285

Open zhapich opened 1 day ago

zhapich commented 1 day ago

Describe the bug ractor code uses tokio methods and types introduced as recently as version 1.40.0, but specifies tokio requirement as version = "1", which means builds fail for users with older versions of tokio already present in their project.

To Reproduce Steps to reproduce the behavior:

  1. In one's project, specify or already have present a version of tokio older than 1.40.0, e.g. ~1.39.0
  2. Run cargo check
  3. Observe errors, e.g. "error[E0599]: no method named join_all found for struct tokio::task::JoinSet in the current scope".

Expected behavior cargo check doesn't complain about ractor.

EDIT: If no one objects, I can go over ractor's dependencies and see if any of them need a version bump and submit a PR; though I'm unable to build ractor-cluster due to some issue involving protobuf, so I'll leave -cluster and friends alone.