search

slaypni / fastdtw

A Python implementation of FastDTW
MIT License
774 stars 122 forks source link

Fix single-dimensional inputs in the pure python impl #28

Closed vmarkovtsev closed 5 years ago

vmarkovtsev commented 5 years ago

Otherwise, I get the following error:

  File "/usr/local/lib/python3.7/dist-packages/fastdtw/fastdtw.py", line 53, in fastdtw
    return __fastdtw(x, y, radius, dist)
  File "/usr/local/lib/python3.7/dist-packages/fastdtw/fastdtw.py", line 73, in __fastdtw
    __fastdtw(x_shrinked, y_shrinked, radius=radius, dist=dist)
  File "/usr/local/lib/python3.7/dist-packages/fastdtw/fastdtw.py", line 73, in __fastdtw
    __fastdtw(x_shrinked, y_shrinked, radius=radius, dist=dist)
  File "/usr/local/lib/python3.7/dist-packages/fastdtw/fastdtw.py", line 73, in __fastdtw
    __fastdtw(x_shrinked, y_shrinked, radius=radius, dist=dist)
  [Previous line repeated 4 more times]
  File "/usr/local/lib/python3.7/dist-packages/fastdtw/fastdtw.py", line 68, in __fastdtw
    return dtw(x, y, dist=dist)
  File "/usr/local/lib/python3.7/dist-packages/fastdtw/fastdtw.py", line 130, in dtw
    return __dtw(x, y, None, dist)
  File "/usr/local/lib/python3.7/dist-packages/fastdtw/fastdtw.py", line 141, in __dtw
    dt = dist(x[i-1], y[j-1])
  File "/usr/local/lib/python3.7/dist-packages/fastdtw/fastdtw.py", line 61, in <lambda>
    return lambda a, b: np.linalg.norm(a - b, p)
  File "/usr/local/lib/python3.7/dist-packages/numpy/linalg/linalg.py", line 2440, in norm
    raise ValueError("Improper number of dimensions to norm.")

on X and Y saved (numpy.save) to https://github.com/src-d/hercules/files/3025826/xy.zip

slaypni commented 5 years ago

@vmarkovtsev Thank you for sending PR! merged.