search

slaypni / fastdtw

A Python implementation of FastDTW
MIT License
785 stars 122 forks source link

cython extensions #3

Closed esquires closed 7 years ago

esquires commented 8 years ago

This is a great library. Thank you for open sourcing it. It would be nice if it ran a bit faster perhaps with cython extensions. Is there any interest in that?

slaypni commented 8 years ago

It would be nice if this library runs faster in that way. I feel this library is not fast when processing non small data although the complexity is O(N).

I have no plan to continue to develop this library, because I have no need to use DTW at this moment. It would be very nice if someone implements it.

esquires commented 8 years ago

Thanks for the feedback. If I fork it and put in a pull request will you incorporate it?

Eric

On Tue, Jul 12, 2016 at 12:03 PM, Tanitter notifications@github.com wrote:

It would be nice if this library runs faster in that way. I feel this library is not very fast when processing non small data although the complexity is O(N).

I have no plan to continue to develop this library, because I have no need to use DTW at this moment. It would be very nice if someone implement it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/slaypni/fastdtw/issues/3#issuecomment-232095253, or mute the thread https://github.com/notifications/unsubscribe/AI17LiQgISjRjPma1nvpS60W0bdUkczuks5qU7rZgaJpZM4JKdUO .

slaypni commented 8 years ago

I will!

esquires commented 8 years ago

see https://github.com/slaypni/fastdtw/pull/4

esquires commented 8 years ago

Given pulls #5 and #6 I think this issue can be closed.

slaypni commented 7 years ago

Close this issue since #5 and #6 were merged.