slco-2016 / clientcomm

A communications platform for case managers in the Criminal Justice System.
https://clientcomm.org/
Other
10 stars 3 forks source link

Sorting on the clients view by date does so incorrectly b/c it treats time as a string #316

Closed kuanb closed 7 years ago

kuanb commented 7 years ago

The value being placed in the attribute being sorted by for date should not be the "string" pretty print of the time but rather an integer of the date in milliseconds. Then, when we are sorting, we should at first check isNaN, if the types are all indeed numbers, we should sort by that first (otherwise go with string).

You can see that it missorted by date in the screen capture in this issue: https://github.com/slco-2016/clientcomm/issues/315