Fix "Current" / "Active" filters on clients index view

slco-2016 / clientcomm

A communications platform for case managers in the Criminal Justice System.

https://clientcomm.org/

Other

10 stars 3 forks source link

Fix "Current" / "Active" filters on clients index view #341

Closed tdooner closed 7 years ago

tdooner commented 7 years ago

These filters were not working on the organizational view of the client index page due to a missing WHERE clause in a sql query.

This adds a ton of regression test coverage too.

Fixes #323

tmaybe commented 7 years ago

I think "closed" was used to a certain extent because it reflects the language that the case managers use; they "close out" clients when they're done managing them. That said, this change only affects a single URL parameter, so I'm fine using "archived" internally.

tdooner commented 7 years ago

Ah okay. Well, I'm cool with either as long as there aren't two synonyms for the same thing. "Archived" is entering the popular lexicon as "the place in cloud services where your stuff sticks around forever" so I think that this is an okay terminology shift to force on our users.