search

slco-2016 / clientcomm

A communications platform for case managers in the Criminal Justice System.
https://clientcomm.org/
Other
10 stars 3 forks source link

Creating a group with 0 or 1 client results in an error #382

Open alsomanya opened 7 years ago

alsomanya commented 7 years ago

Steps to replicate:

  1. As a case manager user, I go to the "+ Groups" button
  2. I enter my group name, select 0 or 1 client, and save group

Result: I get this screen of death: screenshot 2017-03-14 21 40 56

Note: After I got this screen, I used my browser's back button and saw the group in my group list. I sent a test message to it and got a confirmation on screen, but the message never actually sent (I didn't get it on my phone). I think that the group wasn't actually created (per the error message above), even though the UI seems to indicate it was.

tmaybe commented 7 years ago

I can't duplicate this. I do see the behavior you describe if I don't select any clients when creating the group (and that's definitely a bug), but if I select clients, it works fine.

alsomanya commented 7 years ago

Oh, weird! Here's a gif of what I did — I selected a client and got that error screen...

mn5xt5mun0

alsomanya commented 7 years ago

Maybe it's a problem because I'm only adding 1 client — does a group require 2+ clients to work?

tmaybe commented 7 years ago

That's what I was about to test :)

tmaybe commented 7 years ago

Yes, that's it. It works with 2+ clients, errors with 0 or 1 client.

alsomanya commented 7 years ago

Aha! That makes sense, and the error I got for 0 or 1 client is probably more of an edge case (my guess is that the CMs who are creating groups are creating groups with multiple clients). I'll modify the bug description above and we can treat as "known-and-not-urgent".