slds-lmu / ame

average marginal effects for machine learning
Other
1 stars 1 forks source link

Add argument for numDeriv::grad() method #8

Closed BodoBurger closed 6 years ago

giuseppec commented 6 years ago

I think computeAME(other.args, method = "simple") should already work as I am passing this down to derivative(other.args, method = "simple") with the ... arg.

https://github.com/compstat-lmu/ame/blob/aa2b6df252fecf2fa952cf09f550cf7e51166b98/R/derivative.R#L29

BodoBurger commented 6 years ago

Yes, it works.

Ok, then no other argument should be called "method". ;)

And I will document it.