search

slds-lmu / lecture_i2ml

I2ML lecture repository
https://slds-lmu.github.io/i2ml/
Creative Commons Attribution 4.0 International
145 stars 81 forks source link

[Automated] Fix relative figure paths in slides/ #1131

Closed github-actions[bot] closed 11 months ago

github-actions[bot] commented 11 months ago

Automated changes by fix-figure-paths.yaml workflow. Compare and merge to keep figure paths compatible with compilation outside of overleaf.

Explanation:

From what I understand, overleaf automatically tab-completes image paths relative to the project root, e.g. slides/supervised-regression/figure/nutshell-regression-poly-plot-1.pdf - which is apparently fine on overleaf but causes errors when trying to compile slides locally, where paths relative to the folder containing the .tex file are required (i.e. figure/nutshell-regression-poly-plot-1.pdf).

As far as I understand it the latter path should also work on overleaf. To locally auto-fix this, the following command can be used on Linux:

sed -i -E "s\slides/[a-z-]+/figure\figure\g" $(find slides -iname "*.tex")

Which is exactly what this workflow does. Note that macOS requires gnu-sed as the default BSD sed behaves differently.

ludwigbothmann commented 11 months ago

Hi @jemus42 can we merge this? Seems like?

jemus42 commented 11 months ago

I think so, yes. This and the latex-math PR (#1130) should both be fine from what I can tell. I opted not to do the merging myself to not accidentally mess something up while you need the slides stable and working for recording etc.