search

slds-lmu / lecture_i2ml

I2ML lecture repository
https://slds-lmu.github.io/i2ml/
Creative Commons Attribution 4.0 International
146 stars 81 forks source link

[fix] description of make in CONTRIBUTING.md #1166

Closed ludwigbothmann closed 9 months ago

ludwigbothmann commented 9 months ago

:bug: :bug: :bug:

:warning: Please provide specific & actionable issue titles!

Chapter name

Please also flag with corresponding label

No chapter, https://github.com/slds-lmu/lecture_i2ml/blob/master/CONTRIBUTING.md

Location

Please provide as much context as possible, slide numbers change easily

https://github.com/slds-lmu/lecture_i2ml/blob/master/CONTRIBUTING.md#slides

Description & proposed fix

The guide says to use make clean for deleting PDF files, but this does not work anymore, apparently this was changed to make rmpdf? If yes, please update the contributing.md, thanks @lisa-wm !

lisa-wm commented 9 months ago

I'm not quite sure tbh, for me this still works, and the clean target also still exists in the Makefile. Could you please elaborate @ludwigbothmann? On another note, I updated the guidelines regarding compilation (new margin handling) - sorry for the delay :) https://github.com/slds-lmu/lecture_i2ml/pull/1169

ludwigbothmann commented 9 months ago

now I see it as well, it is even more confusing :) in exercises it is make rmpdf in slides it is (as it was always) make clean => any idea why?

lisa-wm commented 9 months ago

Yeah that doesn't make sense, idk why exactly :) I'll change the exercise makefile ➡️ https://github.com/slds-lmu/lecture_i2ml/issues/1170

lisa-wm commented 9 months ago

can we close this one, then @ludwigbothmann?

ludwigbothmann commented 9 months ago

Yes, thx :pray:

lisa-wm commented 9 months ago

Clean makefiles & update contribution guidelines