slds-lmu / yahpo_gym

Surrogate benchmarks for HPO problems
26 stars 2 forks source link

Misspecified range for `momentum` in `lcbench` for paper #48

Closed eddiebergman closed 1 year ago

eddiebergman commented 1 year ago

Just a note that the momentum parameter for the lcbench class of benchmarks says (0.1, 0.9) in the paper but the configspace lists that its (0.1, 0.99):

In [7]: b = BenchmarkSet("lcbench", "3945")

In [8]: b
Out[8]: BenchmarkSet(lcbench)

In [9]: b.get_opt_space()
Out[9]: 
Configuration space object:
  Hyperparameters:
    ...
    momentum, Type: UniformFloat, Range: [0.1, 0.99], Default: 0.545

![Uploading Screenshot_2022-08-24_08-32-39.jpg…]()

sumny commented 1 year ago

Thanks for the issue and nice catch! Indeed the 0.99 as in the configspace seems to be correct: https://github.com/automl/LCBench also states 0.99.

pfistfl commented 1 year ago

Closing here, as the current implementation seems correct