search

sledilnik / website

Webpage source for https://covid-19.sledilnik.org
https://covid-19.sledilnik.org
GNU Affero General Public License v3.0
61 stars 42 forks source link

Anchors on front_page #116

Closed matejmeglic closed 4 years ago

matejmeglic commented 4 years ago

Prosil bi, da še enkrat pogledamo, če se na posamezni graf da dodati anchor (focus), da lahko potem te linke uporabimo za social in za detaljna navodila posameznikom, kaj naj gledajo.

overlordtm commented 4 years ago

Nekaj na tem sem zacel delat, ampak ravno grafi so problematicni, ker se renderajo out of band.

Ok dela za prvi graf https://covid-19.sledilnik.org/#/stats#metrics-comparison-chart Ne dela pa OK za druge grafe https://covid-19.sledilnik.org/#/stats#spread-chart

Pomoje je problem da se grafi "raztegnejo" med nalaganjem strani, tako da se pozicija za scrollTo narobe izracuna

overlordtm commented 4 years ago

Relevantna koda je

Za scrollTo ob navigaciji po strani https://github.com/slo-covid-19/website/blob/master/src/index.js#L89

Za scrollTo ob initial loadu strani (F5 refresh) https://github.com/slo-covid-19/website/blob/master/src/App.vue#L34

lukarenko commented 4 years ago

@overlordtm a si uspel pogledat tale predlog hacka od @VesterDe ?

lukarenko commented 4 years ago

PR: https://github.com/slo-covid-19/website/pull/138

lukarenko commented 4 years ago

For now this is it. We could improve them, but this is for separate issue.