search

sleduc / weechat-xmpp

A fork of the jabber plugin for weechat
21 stars 14 forks source link

Set an away (always False) property on the MUC class #1

Closed CiaranG closed 10 years ago

CiaranG commented 10 years ago

This allows aliases to be set for MUC-related JIDs. Without it, attempting to do so causes a crash.

sleduc commented 10 years ago

Out of curiosity, do you have the traceback related to this missing attribute ? (or a way to reproduce it). I am wondering what code would try to use this on a MUC… (maybe there is a problem somewhere else).

CiaranG commented 10 years ago

I don't have the traceback any more, but it's easy to reproduce. Without this patch:

  1. /jroom room@conference.example.com myname
  2. /jabber alias add room room@conference.example.com <----crash
sleduc commented 10 years ago

Ok thanks, I did not know a "jabber alias" command existed :) I merged the pull request, I also added an "away_string" method to the MUC class, to avoid other tracebacks related to the add/remove of aliases on MUCs.

CiaranG commented 10 years ago

Ok, that's cool - I'd added away_string locally here later for the same reason. :)