search

sleede / fab-manager

Fab-Manager is the FabLab management solution. It provides a comprehensive, web-based, open-source tool to simplify your administrative tasks and your marker's projects.
http://www.fab-manager.com
Other
229 stars 114 forks source link

no option is provided to disable ANSI color escape code #345

Closed trombik closed 2 years ago

trombik commented 2 years ago

Describe the bug

in rails 5.x, config.colorize_logging is true by default. users cannot disable ANSI color escape code in the log.

To Reproduce

  1. run rails db:seed
  2. See the log

Expected behavior

There should be an option to disable color in the log.

Screenshots

N/A

Server (please complete the following information):

Browser (please complete the following information):

Additional context

as an admin, i would like to log to file or syslog. logs in color does not look nice in this context. see an example in color at https://github.com/trombik/ansible-role-fab_manager/runs/6353345075?check_suite_focus=true

sylvainbx commented 2 years ago

Thanks for your contribution @trombik. Your PR has been merged and will be released in Fab-manager v5.4.1

trombik commented 2 years ago

@sylvainbx thank you. a question. I haven't seen a commit that mentions the PR. some commits seems to go directly into master. how do you manage develop-merge-release workflow?

sylvainbx commented 2 years ago

It seems like we forget to put the issue ID in the merge-commit message. Anyway, all changes must go to the dev branch or onto a new branch based on dev which will be merged on, once the development is over. Only once eveything on dev is ready to go to production, we merge the dev branch onto master and create a new release.

trombik commented 2 years ago

@sylvainbx okay. PR > dev > master looks reasonable. thanks for the clarification.

trombik commented 2 years ago

another question: what convention do you follow in commit logs? looks like you prefer prefixes like (setup), (bug), or (security).

i roughly follow the Conventional Commits.

bugfix: fix something

fixes #123. X was replaced with Y because Z.

https://www.conventionalcommits.org/en/v1.0.0/

do you have a guidance of possible prefixes or a standard of commit logs?