search

sleede / fab-manager

Fab-Manager is the FabLab management solution. It provides a comprehensive, web-based, open-source tool to simplify your administrative tasks and your marker's projects.
http://www.fab-manager.com
Other
229 stars 114 forks source link

(bug) Fix SSO data being overridden when it is empty and the user can change it #377

Closed Guichaguri closed 2 years ago

Guichaguri commented 2 years ago

When some data is not present in SSO, the user can change it (it is not present in mapped_from_sso), but as soon as they login again, the data is replaced.

This fixes this issue by using the same logic to add them in mapped_from_sso to actually map the property, also making all properties consistent, as all of them now ignore null properties.

I found this issue while testing the "birthday" property: the user was redirected every login to the profile completion page because when they logged in the birthday property was removed.

Guichaguri commented 2 years ago

I've missed that, thanks! Fixed now :)