(Bug) Fix (once again) admin users groups being overriden by SSO group_id

sleede / fab-manager

Fab-Manager is the FabLab management solution. It provides a comprehensive, web-based, open-source tool to simplify your administrative tasks and your marker's projects.

http://www.fab-manager.com

Other

229 stars 114 forks source link

(Bug) Fix (once again) admin users groups being overriden by SSO group_id #404

Closed Guichaguri closed 2 years ago

Guichaguri commented 2 years ago

When SSO is enabled mapping the group id, the group is overridden even when the user is admin and is supposed to be in the "admins" group.

This was "fixed" before in #376, which did not work. I think it's because it was checking whether the user is an admin based on the temporary user, and not the actual one. Please, can you check if this one is in the correct path?

Thank you

Guichaguri commented 2 years ago

@sylvainbx Am I in the correct path in this one? Thanks.

sylvainbx commented 2 years ago

I guess this is ok. This part is hard to test, but it should not impact anything else so if it doesn't do the job, please feel free to create a new PR :wink: