search

sleemanj / xinha

WYSIWYG HTML Editor Component (turns <textarea> into HTML editors)
http://trac.xinha.org/
Other
13 stars 2 forks source link

Linker plugin defines a global "Node" object (Trac #1619) #1619

Closed sleemanj closed 3 years ago

sleemanj commented 10 years ago

The Linker plugin defines a global object "Node". This overwrites modern browsers' built-in [https://developer.mozilla.org/en-US/docs/Web/API/Node Node object], which can cause surprising side-effects in other plugin code that expects to be able to use it, e.g. to access constants like Node.TEXT_NODE.

Linker should either rename its node class, or not export it into the global namespace, or both.

Reported by ejucovy, migrated from http://trac.xinha.org/ticket/1619

sleemanj commented 10 years ago

Fixed in 1331

(Pushing some long ago updates from my local repos)