sleemanj / xinha

WYSIWYG HTML Editor Component (turns <textarea> into HTML editors)
http://trac.xinha.org/
Other
13 stars 2 forks source link

PHP scripts in contrib folder need "<?php" at the top of the script. (Trac #1625) #1625

Closed sleemanj closed 3 years ago

sleemanj commented 10 years ago

The opening line of the php scripts in the contrib folder need to switch from "<?" to "<?php" else PHP command-line (via php compress.php) can't run them. (See: http://www.w3schools.com/php/php_syntax.asp)

Also, in the base folder, compression_readme.txt, it claims we can run the PHP scripts using our web browser but neither Chrome nor Firefox were able to activate PHP (seems strange, I didn't know browsers can run PHP OOTB.) I would change the text from:

To use this script, open it in a text editor, comment out the die() command at the top and open it in your browser.

to:

Make sure you have PHP installed on your machine. To use this script, open it in a text editor, comment out the die() command at the top and run via "php compress.php" from the command-line.

Reported by guest, migrated from http://trac.xinha.org/ticket/1625

sleemanj commented 10 years ago

Thanks for catching this -- I'll commit these changes shortly.

sleemanj commented 10 years ago

1333 1334