search

sleemanj / xinha

WYSIWYG HTML Editor Component (turns <textarea> into HTML editors)
http://trac.xinha.org/
Other
13 stars 2 forks source link

make it possible to choose from different icon sets (Trac #326) #326

Closed sleemanj closed 3 years ago

sleemanj commented 19 years ago

The icons I submitted on the forum could be used in the distrobution if you want. The links are on my post: http://xinha.gogo.co.nz/punbb/viewtopic.php?id=89

Reported by riftdesign, migrated from http://trac.xinha.org/ticket/326

sleemanj commented 19 years ago

here's the icons Attachment: xinhaIconSet.zip

sleemanj commented 19 years ago

gocher commented:

It would be nice to set iconsets depending on skins!

  • create a default skin with img folder (the old images)
  • create to any other skin an iconset like yours or copy the old but then every plugin must have a skin directory for the images of the plugin

Is that possible or is there a better way?

sleemanj commented 19 years ago

niko commented:

we have to think about:

  • plugins have icons too - we would need the icons for the plugins in the skin-folder (or the other way around, skin-folders in the plugin)
  • we have to take care about #39
sleemanj commented 19 years ago

Committed the icons in changeset:264

having different icons per skin would be... troublesome. Perhaps for V2.0, I'll leave the ticket open but change the milestone.

sleemanj commented 19 years ago

kimss commented:

Plugins need icons to, but placing the skins inside the plugins folders would not be practical in the real world. A skin should be a folder which includes x images.

I would think that if its possible, a Xinha skin is defined and concists of x images. All the images existing in a skin will be used first, if it doesnt exist it will be loaded from the plugins folder.

This sounds to me that the skin directory will need an extra xml fil containing a list of all the images inside the skin and what plugin they belong to. Then the plugin must define the images it wants to use. This way we pick the skin image if it exist or the plugin image if the skin isnt updated.

It could be done much simpler also, "Force skin", would mean that all images is supposed to be in the skin folder. Meaning that we get alot of missing images in the editor if the skin isnt updated, our resposibility would then be to have updated skins - which shouldnt be much of a problem really?

Or maby its easier to incorporate a skin structure inside the plugins aswell? For those who likes to strip down an installation it would be many directories to delete however and could be looked upon as very "timeconsuming". (I know its easy to search fir directories, so it can be done fast aswell).

Some ideas anyways; D

sleemanj commented 19 years ago

ray changed milestone from 2.0 to 0.96

sleemanj commented 19 years ago

I have done a patch to make this possible; I will commit this shortly

sleemanj commented 19 years ago

ray changed summary from Have different icons per skin. to make it possible to choose from different icon sets

sleemanj commented 19 years ago

rev 1113: there is now the posibility to define named icon sets that can be loaded by adding

_editor_icons = "nameoftheset";

to the document, or a skin can recommend a specific set via its XML file.

The set itself is define by an XML file that lists each icon that is replaced, including i18n

I have already included two sets, the classic Xinha icons (for the more conservative characters ;)) and the Crystal Open Office icons