search

sleeper / rack-auth-krb

Kerberos authentication (Basic and SPNEGO)
19 stars 8 forks source link

Refactor codebase #3

Closed danielfarrell closed 12 years ago

danielfarrell commented 12 years ago

So, I hope you have thick skin, because the girlfriend is out of town this weekend and I just went to town on this codebase.

I tried to go for single responsibility, code encapsulation, and single exit path of methods as much as possible.

If it's too much let me know.

sleeper commented 12 years ago

Impressive work !!!!! I'm merging it in, and will do further tests tomorrow on a kerberos-configure machine (actually, on my Mac, compiling/configuring kerberos is a pain in the **s ... even tried to write my first homebrew formula to get rid of that ..)

danielfarrell commented 12 years ago

Cool. Yeah, I dev on a mac as well, I've got an ubuntu virtual machine that I was using for the testing.

sleeper commented 12 years ago

Yep ... I'm going to do this asap ... vagrant is my friend ;)