sleevezipper / hass-workstation-service

Provide useful sensors and services from your workstation to Home Assistant.
Apache License 2.0
613 stars 54 forks source link

Add master volume sensor. #123

Closed SecretiveShell closed 2 years ago

SecretiveShell commented 2 years ago

Because #90 has gone stale, I converted the code into a new sensor and update GUI and documentation to reflect this.

sleevezipper commented 2 years ago

Hi! Thanks for creating a new PR. The sensor should also be configurable through the UI. Would you mind adding that?

SecretiveShell commented 2 years ago

After making a new directory and cloning my develop branch, I have failed to replicate this issue. Here is the list of commands I used to recreate the test build :

git clone --branch develop https://github.com/SecretiveShell/hass-workstation-service
cd .\hass-workstation-service\
mkdir build
dotnet build
dotnet publish --output .\build\
cd .\build
explorer .

After closing the installed version of HWS using task manager I was able to initialize the new one and successfully configure the command

build log.txt

mark007 commented 2 years ago

This is a great addition. When will there be an official release/build for those of us who do not have the dotnet build tools.

mark007 commented 2 years ago

Were you also planning to add a SetVolumeComand from your end @SecretiveShell or is it something you would consider? My goal is to update some HA automations when I click certain "Activities" on a harmony remote, so for "Play Games" I wanted to set TV HDMI inputs (done), set wireless speaker inputs to say Optical (done), as well as set the wireless speaker volume (done) and set an appropriate windows master volume (to do). I guess for the set volume to work, it would need to be able to take variables into the command.

SecretiveShell commented 2 years ago

That would be a nice addition, although I currently have no plans to implement this. It would require a rework of how the app handles MQTT messages.