MidiLooper: Improve piano roll and editor code structure

sleiner / pizmidi

A collection of helpful tools when working with MIDI

GNU General Public License v3.0

23 stars 4 forks source link

MidiLooper: Improve piano roll and editor code structure #29

Open loowps opened 1 year ago

loowps commented 1 year ago

Improvements:

Add basic piano roll zoom and scroll via mousewheel
Sharper drawing of piano roll notes and lines

Refactoring:

Remove projucer metadata
Extract some inner components / classes
Adapt piz looper editor structure to match current ui
Replace some listeners with callbacks and extracted methods
Remove translation macro usage

loowps commented 1 year ago

@sleiner let me know if you think this PR is worthwile.. tbh my ambitions were a little bit greater (refactor it properly, make it fully resizable with fixed width piano roll and add brush mode) but midway I realized that this is not something I can do within some days and if ever will only be realized in smaller steps..

loowps commented 2 months ago

Just a heads up that projucer gui editor has been removed with Juce 8 https://github.com/juce-framework/JUCE/blob/master/BREAKING_CHANGES.md#change-2