sleistner / vscode-fileutils

Visual Studio Code Extension
https://marketplace.visualstudio.com/items?itemName=sleistner.vscode-fileutils
MIT License
190 stars 26 forks source link

Deleting file via tab removes incorrect file and discards any unsaved changes (severe 🚨) #330

Closed adamreisnz closed 3 years ago

adamreisnz commented 3 years ago

Issue Type: Bug

See screen recording: https://www.loom.com/share/6858657ab50f416997a0b2777698d759

  1. Open 2 files
  2. Edit one of the files (optional) and keep focus on this file's editor window
  3. Right click on tab of the other file (which doesn't have focus) and choose Delete
  4. Observe how the first file with the focus is deleted instead
  5. Observe how the tab is also closed and not preserved with a (deleted) suffix
  6. Observe how if you had unsaved changes in this file these are now lost

This is consistently reproducible and on account of not saving the contents in the file that is incorrectly removed, a very severe bug in my opinion.

Extension version: 3.4.3 VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-11T01:11:34.018Z) OS version: Darwin x64 19.6.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-1060NG7 CPU @ 1.20GHz (8 x 1200)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|3, 3, 3| |Memory (System)|16.00GB (0.14GB free)| |Process Argv|--crash-reporter-id 006a2d24-d7bd-4f93-aadc-2c2054511bf1| |Screen Reader|no| |VM|0%|
sleistner commented 3 years ago

:tada: This issue has been resolved in version 3.4.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: