Closed Indigo744 closed 4 years ago
Issue on original repo: https://github.com/kogitant/sonar-slack-notifier-plugin/issues/31
Sadly, I fail to see anything useful in the changelogs of SQ 8.0: https://docs.sonarqube.org/latest/setup/upgrade-notes/ Full release note: https://jira.sonarsource.com/secure/ReleaseNote.jspa?projectId=10930&version=14962
It looks like something linked with JDK 11 ?
On Thu, Dec 12, 2019 at 2:58 PM Guillaume notifications@github.com wrote:
Sadly, I fail to see anything useful in the changelogs of SQ 8.0: https://docs.sonarqube.org/latest/setup/upgrade-notes/ Full release note: https://jira.sonarsource.com/secure/ReleaseNote.jspa?projectId=10930&version=14962
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sleroy/sonar-slack-notifier-plugin/issues/2?email_source=notifications&email_token=ABL7XEXLJKZUYMMAGHDFQHLQYI7RTA5CNFSM4JZ6265KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGWXZII#issuecomment-565017761, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL7XEVJHPL74TCKUYVR3ETQYI7RTANCNFSM4JZ6265A .
Seems the rest client okhttp3 has some issues with JDK11 (used by the plugin)
Interesting.
I am sadly not very good in Java so I won't be able to help much in the code, but tell me if I can be of help.
Should I try to update JDK or something?
No, I need to make a new release of the plugin with some upgraded dependencies.
I am producing a new version and will release it today. Please give me a feedback then if it solves your issue.
Please try this version : https://github.com/sleroy/sonar-slack-notifier-plugin/releases/tag/2.6.0
Remove the older version. and Install the new one in your plugin folder
Wow you are fast! I'll do it right away. Although our build process takes approximately 30 minutes to complete... Sorry...
@sleroy Sorry but I fail to find the JAR file?
my bad, the artifact did not upload: Here is the link https://github.com/sleroy/sonar-slack-notifier-plugin/releases/download/2.6.0/cks-slack-notifier-2.6.0.jar
Build started, I'll let you know! 🤞
Well, everything went fine but the result was not sent to Slack 😞
In the log, there is this weird error:
2019.12.12 16:25:13 INFO ce[AW76sQNp757ywNdbTWkx][c.k.s.s.c.c.AbstractSlackNotifyingComponent] SlackNotifierProp.CONFIG=[[]]
2019.12.12 16:25:13 INFO ce[AW76sQNp757ywNdbTWkx][c.k.s.s.e.t.SlackPostProjectAnalysisTask] Slack notifier plugin disabled, skipping. Settings are [{CONFIG=, HOOK=, PROXY_IP=, INCLUDE_BRANCH=false, ENABLED=false, USER=SonarQube, PROXY_PORT=8080, PROXY_PROTOCOL=HTTP}; project specific channel config: {}]
2019.12.12 16:25:13 ERROR ce[AW76sQNp757ywNdbTWkx][o.s.c.t.s.ComputationStepExecutor] Execution of listener failed
java.lang.AbstractMethodError: Receiver class com.koant.sonar.slacknotifier.extension.task.SlackPostProjectAnalysisTask does not define or inherit an implementation of the resolved method abstract getDescription()Ljava/lang/String; of interface org.sonar.api.ce.posttask.PostProjectAnalysisTask.
at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.executeTask(PostProjectAnalysisTasksExecutor.java:124)
at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.finished(PostProjectAnalysisTasksExecutor.java:109)
at org.sonar.ce.task.step.ComputationStepExecutor.executeListener(ComputationStepExecutor.java:91)
at org.sonar.ce.task.step.ComputationStepExecutor.execute(ComputationStepExecutor.java:63)
at org.sonar.ce.task.projectanalysis.taskprocessor.ReportTaskProcessor.process(ReportTaskProcessor.java:81)
at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.executeTask(CeWorkerImpl.java:209)
at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.run(CeWorkerImpl.java:191)
at org.sonar.ce.taskprocessor.CeWorkerImpl.findAndProcessTask(CeWorkerImpl.java:158)
at org.sonar.ce.taskprocessor.CeWorkerImpl$TrackRunningState.get(CeWorkerImpl.java:133)
at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:85)
at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:53)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
It says plugin is disabled even though it is enabled in the configuration:
This is another error. My plugin has been tested on the LTS 7.2+ version. The version 8 is not yet supported.
Creates another issue please.
On Thu, Dec 12, 2019 at 4:34 PM Guillaume notifications@github.com wrote:
In the log, there is this weird error:
2019.12.12 16:25:13 INFO ce[AW76sQNp757ywNdbTWkx][c.k.s.s.c.c.AbstractSlackNotifyingComponent] SlackNotifierProp.CONFIG=[[]] 2019.12.12 16:25:13 INFO ce[AW76sQNp757ywNdbTWkx][c.k.s.s.e.t.SlackPostProjectAnalysisTask] Slack notifier plugin disabled, skipping. Settings are [{CONFIG=, HOOK=, PROXY_IP=, INCLUDE_BRANCH=false, ENABLED=false, USER=SonarQube, PROXY_PORT=8080, PROXY_PROTOCOL=HTTP}; project specific channel config: {}] 2019.12.12 16:25:13 ERROR ce[AW76sQNp757ywNdbTWkx][o.s.c.t.s.ComputationStepExecutor] Execution of listener failed java.lang.AbstractMethodError: Receiver class com.koant.sonar.slacknotifier.extension.task.SlackPostProjectAnalysisTask does not define or inherit an implementation of the resolved method abstract getDescription()Ljava/lang/String; of interface org.sonar.api.ce.posttask.PostProjectAnalysisTask. at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.executeTask(PostProjectAnalysisTasksExecutor.java:124) at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.finished(PostProjectAnalysisTasksExecutor.java:109) at org.sonar.ce.task.step.ComputationStepExecutor.executeListener(ComputationStepExecutor.java:91) at org.sonar.ce.task.step.ComputationStepExecutor.execute(ComputationStepExecutor.java:63) at org.sonar.ce.task.projectanalysis.taskprocessor.ReportTaskProcessor.process(ReportTaskProcessor.java:81) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.executeTask(CeWorkerImpl.java:209) at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.run(CeWorkerImpl.java:191) at org.sonar.ce.taskprocessor.CeWorkerImpl.findAndProcessTask(CeWorkerImpl.java:158) at org.sonar.ce.taskprocessor.CeWorkerImpl$TrackRunningState.get(CeWorkerImpl.java:133) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:85) at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:53) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)
It says plugin is disabled even though it is enabled in the configuration: [image: image] https://user-images.githubusercontent.com/7137528/70725790-4f3e2d80-1cfd-11ea-9652-e8993c9e6639.png
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sleroy/sonar-slack-notifier-plugin/issues/2?email_source=notifications&email_token=ABL7XEQ7N5EH4NXDX5N3UH3QYJKZ7A5CNFSM4JZ6265KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGXBRRQ#issuecomment-565057734, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL7XEQDCPK3MVWAMC4GEZ3QYJKZ7ANCNFSM4JZ6265A .
Why should I create another issue? This issue concerns SonarQube 8.0, as stated in the title.
Of course the version 8 is not yet supported. This is why this issue exists in the first place!
I am having the same issue running SonarQube 8.0.
SonarQube version : 8.0.0.29455 CKS Slack Notifier version : 2.6.0
2019.12.19 17:09:25 INFO ce[AW8fIphInpZ1RQ180HoG][c.k.s.s.c.c.AbstractSlackNotifyingComponent] SlackNotifierProp.CONFIG=[[]]
2019.12.19 17:09:25 INFO ce[AW8fIphInpZ1RQ180HoG][c.k.s.s.e.t.SlackPostProjectAnalysisTask] Slack notifier plugin disabled, skipping. Settings are [{CONFIG=, HOOK=, PROXY_IP=, INCLUDE_BRANCH=false, ENABLED=false, USER=SonarQube, PROXY_PORT=8080, PROXY_PROTOCOL=HTTP}; project specific channel config: {}]
2019.12.19 17:09:25 ERROR ce[AW8fIphInpZ1RQ180HoG][o.s.c.t.s.ComputationStepExecutor] Execution of listener failed
java.lang.AbstractMethodError: Receiver class com.koant.sonar.slacknotifier.extension.task.SlackPostProjectAnalysisTask does not define or inherit an implementation of the resolved method 'abstract java.lang.String getDescription()' of interface org.sonar.api.ce.posttask.PostProjectAnalysisTask.
at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.executeTask(PostProjectAnalysisTasksExecutor.java:124)
at org.sonar.ce.task.projectanalysis.api.posttask.PostProjectAnalysisTasksExecutor.finished(PostProjectAnalysisTasksExecutor.java:109)
at org.sonar.ce.task.step.ComputationStepExecutor.executeListener(ComputationStepExecutor.java:91)
at org.sonar.ce.task.step.ComputationStepExecutor.execute(ComputationStepExecutor.java:63)
at org.sonar.ce.task.projectanalysis.taskprocessor.ReportTaskProcessor.process(ReportTaskProcessor.java:81)
at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.executeTask(CeWorkerImpl.java:209)
at org.sonar.ce.taskprocessor.CeWorkerImpl$ExecuteTask.run(CeWorkerImpl.java:191)
at org.sonar.ce.taskprocessor.CeWorkerImpl.findAndProcessTask(CeWorkerImpl.java:158)
at org.sonar.ce.taskprocessor.CeWorkerImpl$TrackRunningState.get(CeWorkerImpl.java:133)
at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:85)
at org.sonar.ce.taskprocessor.CeWorkerImpl.call(CeWorkerImpl.java:53)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
2019.12.19 17:09:25 INFO ce[AW8fIphInpZ1RQ180HoG][o.s.c.t.CeWorkerImpl] Executed task | project=vivoom-render2 | type=REPORT | branch=master | branchType=LONG | id=AW8fIphInpZ1RQ180HoG | submitter=admin | status=SUCCESS | time=6381ms
Why should I create another issue? This issue concerns SonarQube 8.0, as stated in the title.
Of course the version 8 is not yet supported. This is why this issue exists in the first place!
No need to argue. The issue you copy/pasted previously is not linked to SonarQube 8,0 but JDK11 and has been solved. There is another issue or rather a feature request to make the plugin compatible. with SonarQube 8.0 and I will fix it as well.
@sleroy sorry didn't mean to snap at you. I'll open a new issue.
I have been working on your issue this week (I have already done some commits). I hope to release a new version next week, XMas gift :-)
Best,
Sylvain
On Sat, Dec 21, 2019 at 12:05 PM Guillaume notifications@github.com wrote:
@sleroy https://github.com/sleroy sorry didn't mean to snap at you. I'll open a new issue.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sleroy/sonar-slack-notifier-plugin/issues/2?email_source=notifications&email_token=ABL7XETE74TRIGHWKVMXPBLQZXZ6RA5CNFSM4JZ6265KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHOZ7CQ#issuecomment-568172426, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL7XERG6LWC5LFTE3XNLUDQZXZ6RANCNFSM4JZ6265A .
Thank you so much 😸
I am closing the ticket. I am not maintaing actively the plugin since the feature is defacto provided by SonarQube with their SonarJS plugin.
Thank you for your message and sorry for the inconvenience.
SonarQube version : 8.0.0.29455 CKS Slack Notifier version : 2.5
Here is the error:
Thanks.