search

sleroy / sonar-slack-notifier-plugin

SonarQube plugin for sending notifications to Slack
Other
40 stars 17 forks source link

Feature Request: Support both JDK 8 and JDK 11 #5

Open wyyang opened 4 years ago

wyyang commented 4 years ago

In many orgs both JDK 8 and JDK 11 are used at different teams. The current version of the plug in stops people using JDK 8 from using SonarQube to parse their code. It will be best if both are supported. Thanks!

sleroy commented 4 years ago

I agree with you but at this time, I'm alone to maintain this plugin and with my limited time, I cannot maintain several versions at the same time.

I have as many requests for supporting the upcoming versions as the previous ones.

If you want me to maintain the older version or some improvements, you can always contract with me.

Best regards

Sylvain

Le jeu. 23 janv. 2020 à 20:21, wyyang notifications@github.com a écrit :

In many orgs both JDK 8 and JDK 11 are used at different teams. The current version of the plug in stops people using JDK 8 from using SonarQube to parse their code. It will be best if both are supported. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sleroy/sonar-slack-notifier-plugin/issues/5?email_source=notifications&email_token=ABL7XESYYPHSVKNZQNRSJ7DQ7HU4HA5CNFSM4KK3UW42YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIKY7NQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL7XEW4QRHMQFMDOFDW6NTQ7HU4HANCNFSM4KK3UW4Q .

wyyang commented 4 years ago

Are there specific JDK 11 code or is it just a compilation configuration? Also, when I tried to compile the code, it failed with error 

[ERROR] Failed to execute goal org.sonarsource.sonar-packaging-maven-plugin:sonar-packaging-maven-plugin:1.18.0.372:sonar-plugin (default-sonar-plugin) on project sonar-slack-notifier: Plugin class not found: 'com.byoskill.sonar.slacknotifier.SlackNotifierPlugin -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.sonarsource.sonar-packaging-maven-plugin:sonar-packaging-maven-plugin:1.18.0.372:sonar-plugin (default-sonar-plugin) on project sonar-slack-notifier: Plugin class not found: 'com.byoskill.sonar.slacknotifier.SlackNotifierPlugin

I tried both with latest in master branch, or tagged to 8.0.0 beta. Did I set up my environment wrong? Thanks.