search

sleuth-io / code-video-generator

Generates code walkthrough videos using Manim
Apache License 2.0
244 stars 16 forks source link

Upgrade to manim 0.8.0 #4

Closed krashanoff closed 3 years ago

krashanoff commented 3 years ago

Just wanted to update this program for folks to use with the latest version of manim.

Only relevant change between 0.4.0 and 0.8.0 that I could find is that ShowCreation was deprecated, and then deleted, in favor of Create in version 0.7.0 (see here). Updated the source and examples to reflect.

mrdon commented 3 years ago

Looks great, thanks! I think the version of manim also needs to be bumped, but I can do that

mrdon commented 3 years ago

Looks like the format build failed. Could you please bump setup.cfg at the same time?

krashanoff commented 3 years ago

I'll push the two requested changes in the next ~12 hours. Thanks for the quick reply!

krashanoff commented 3 years ago

Turned into a little more than I anticipated. There was a change in the manim CLI that I updated in the Makefile, and removal of certain properties from Mobjects like font in VGroup.

I updated the interface of this package so that it is backwards-compatible by taking the font property through relevant classes (see widgets.py:L109), or the height property in ImageMobject (see scene.py:L142).

mrdon commented 3 years ago

I'm getting errors against 0.9 --dry_run invalid or some such

krashanoff commented 3 years ago

Apologies on the radio silence on this. I am currently in between an internship and the start of the academic year. The --dry_run option doesn't seem to work anymore as a flag or as a configuration option, which is strange. I documented it in an issue on the ManimCommunity repo. For now, removing the --dry_run option from the Docker tests should fix it. Was there a critical reason it was set?