Feat: Add types - Githubissues

slevithan / regex

Context-aware regex template tag with advanced features and best practices built-in

MIT License

235 stars 4 forks source link

Feat: Add types #4

Open slevithan opened 2 weeks ago

slevithan commented 2 weeks ago

I would be happy to add types to regex, along with its extension regex-recursion and their shared utilities regex-utilities.

I'd love help with this or for someone to take over this issue. The types are fairly complex and I'm not yet well-versed with TypeScript.

rauschma commented 2 days ago

I have never written .d.ts files manually, but this should work: https://github.com/rauschma/regex-types
It should be enough to move index.d.ts next to index.js (no need to change package.json).
Tool for checking if everything worked out: https://github.com/arethetypeswrong/arethetypeswrong.github.io

slevithan commented 2 days ago

Amazing--thank you!!

Can I interest you in submitting this as a PR? 😊 I'd love for your work to be officially credited in the contributors list. If not, I'll come back to this later and figure it out. Either way, thanks!

PS: I'm a longtime fan of your JS and regex work/writing. I'd love to add you as a collaborator for the repo if at any point you're interested in being more involved.

rauschma commented 2 days ago

Can I interest you in submitting this as a PR?

I just did: https://github.com/slevithan/regex/pull/6

I'm a longtime fan of your JS and regex work/writing.

Cool! I’ve also been a fan of your work for a long time. Proof 😀 (written in 2014): https://exploringjs.com/es5/ch30.html#_four_language_libraries

I'd love to add you as a collaborator for the repo if at any point you're interested in being more involved.

I have too many other projects that I’m working on at the moment, but I’ll keep it in mind.