search

slevithan / xregexp

Extended JavaScript regular expressions
http://xregexp.com/
MIT License
3.31k stars 278 forks source link

Updated types def and tests #288

Closed pristinesource closed 4 years ago

pristinesource commented 4 years ago

Created here from https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43115 as per request from @jfahrenkrug

josephfrazier commented 4 years ago

Thanks, especially for the link to the DefinitelyTyped PR! I eyeballed this one against as a sanity check, and it seems fine. I'm hoping to be able to make a new release sometime this week.

josephfrazier commented 4 years ago

I'm hoping to be able to make a new release sometime this week.

Hmm actually, it looks like I no longer have NPM public permissions, according to npm owner ls xregexp, so we might have to wait for @slevithan if we want to get a new version out, containing the changes since v4.3.0.

slevithan commented 4 years ago

@josephfrazier I haven’t changed anything so I think you should still be able to publish. I just checked the xregexp package settings on npmjs.com and you have write access.