Added babel plugin and loop export

slevithan / xregexp

Extended JavaScript regular expressions

http://xregexp.com/

MIT License

3.31k stars 278 forks source link

Added babel plugin and loop export #299

Closed Piterden closed 3 years ago

Piterden commented 4 years ago

Added plugin proposal export namespace from. And shortened some exports.

josephfrazier commented 3 years ago

Thanks for the PR, @Piterden! I'm a little hesitant to merge it, though, as the proposal is currently only at Stage 1: https://github.com/tc39/proposal-export-default-from, and I'm not sure if it's worth the ~same~ small amount of code cleanup it allows

slevithan commented 3 years ago

Agree with @josephfrazier. I don't think this adds enough improvement to justify the additional dependency, especially if the TC39 proposal is not on a clear track to approval. I'm going to close this, but we can always reopen later if we made the wrong call here. Thanks for the PR though, @Piterden -- it's interesting to see.