search

slevithan / xregexp

Extended JavaScript regular expressions
http://xregexp.com/
MIT License
3.31k stars 278 forks source link

Use GitHub Actions instead of Travis CI #309

Closed josephfrazier closed 3 years ago

josephfrazier commented 3 years ago

Travis CI is no longer providing CI minutes for open source projects: https://news.ycombinator.com/item?id=25338983

It's also been pretty slow: the build for https://github.com/slevithan/xregexp/pull/308 hasn't started in 13 minutes

The config file is based on the template at https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-nodejs#specifying-the-nodejs-version

slevithan commented 3 years ago

Can we also replace the Travis CI build status badge at the top of README.md with something equivalent?

josephfrazier commented 3 years ago

Good call, I'll try to see if I can find something.

It looks like we'll need to manually enable the workflow once this is merged: https://docs.github.com/en/free-pro-team@latest/actions/managing-workflow-runs/disabling-and-enabling-a-workflow

But, I'm still working on fixing a bug in it: https://github.com/josephfrazier/xregexp/actions/runs/407379254

slevithan commented 3 years ago

Good call, I'll try to see if I can find something.

Maybe it's for the best to just kill the badge anyway, since the readme shows up on npm and elsewhere.

josephfrazier commented 3 years ago

But, I'm still working on fixing a bug in it: josephfrazier/xregexp/actions/runs/407379254

ok, looks like we're good now: https://github.com/josephfrazier/xregexp/runs/1515139490?check_suite_focus=true