search

slevomat / coding-standard

Slevomat Coding Standard for PHP_CodeSniffer provides many useful sniffs
MIT License
1.37k stars 170 forks source link

Revert "replace squizlabs/php_codesniffer with phpcsstandards/php_codesniffer" #1646

Closed jrfnl closed 7 months ago

jrfnl commented 7 months ago

Revert "replace squizlabs/php_codesniffer with phpcsstandards/php_codesniffer"

This reverts commit 271394724bf57dd77819f766c450d5543d9c9ab3.

See: https://github.com/slevomat/coding-standard/pull/1641#issuecomment-1843958153

Also: https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.0

TestCase: update for new Ruleset::$properties format

Related to the handling of the PHP 8.2 dynamic properties deprecation.

Note: this issue will not block end-users, it is only the test suite which is affected.

Refs:

kukulich commented 7 months ago

Thanks.

janedbal commented 6 months ago

Is this really good idea?

I think that since old repo does not contain releases, dependabot summaries are not as good anymore. See e.g. https://github.com/editorconfig-checker/editorconfig-checker.php/pull/298

janedbal commented 6 months ago

And I mean using proper package name in general, not in this particular repository.

jrfnl commented 6 months ago

Is this really good idea?

I think that since old repo does not contain releases, dependabot summaries are not as good anymore. See e.g. editorconfig-checker/editorconfig-checker.php#298

Yes it is. The package name ended up not being changed and Packagist was updated to look at the new repo, so releases will now be taken from the new repo. If Dependabot does not handle this correctly, you need to report a bug there.

For the record, this means that the "proper package name" is still squizlabs/php_codesniffer and any repo which points to phpcsstandards/php_codesniffer should revert that change (and runs the risk of the package at some point not working anymore).

janedbal commented 6 months ago

any repo which points to phpcsstandards/php_codesniffer should revert that change (and runs the risk of the package at some point not working anymore)

Why? Can you describe/link some more details on this topic? Thx

jrfnl commented 6 months ago

any repo which points to phpcsstandards/php_codesniffer should revert that change (and runs the risk of the package at some point not working anymore)

Why? Can you describe/link some more details on this topic? Thx

Because that name will be taken offline as soon as possible, or at the very least marked as abandoned.