sleyzerzon / soar

Automatically exported from code.google.com/p/soar
1 stars 0 forks source link

excise -t should not also perform init #112

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Right now it seems like issuing an excise -t will also reinit the Soar agent, 
which is not the behavior specified in the command documentation wiki. We 
should remove the automatic init.

Furthermore, I also don't understand why excise -a should automatically perform 
an init either. To me these are two completely different operations. When users 
programmatically issue these commands from SML, they are not going to see the 
"Agent reinitialized" output, and they may not realize the init happened (which 
is what happened to me just now).

Just like we disabled the automatic switching to epsilon-greedy when rl is 
enabled to prevent things from happening behind the user's back, we should also 
prevent the automatic init after excise -t and excise -a.

Original issue reported on code.google.com by joseph...@gmail.com on 24 Jun 2012 at 9:16

GoogleCodeExporter commented 8 years ago
I'm pretty sure the excise -all + init behavior is very old (i.e., before our 
time). The likely rationale is that there's no reason to do an ex -a without 
doing an init, but forgetting to do an init could cause strange behavior, so 
it's just built-in. I don't know if this is true for ex -t -- I'm going to go 
out on a limb here and guess that you've run into a case where it is not true, 
in which case disabling it in that case may make sense.

I don't think it's directly analogous to the epsilon-greedy behavior, though -- 
unlike that, there may be a lot of old code that depends on the current 
behavior for -a (but probably no one else uses -t, so changing that is probably 
safe).

Original comment by marin...@gmail.com on 25 Jun 2012 at 1:06

GoogleCodeExporter commented 8 years ago
I just searched the old pre-8.6 tree, excise all re-inits Soar: 
http://code.google.com/p/soar/source/search?q=soar_cExciseAllProductions&origq=s
oar_cExciseAllProductions&btnG=Search+Trunk soar_core_api.c 1141

Original comment by voigtjr@gmail.com on 25 Jun 2012 at 1:13