sleyzerzon / soar

Automatically exported from code.google.com/p/soar
1 stars 0 forks source link

Incorrect id printed in GDS removal messages #75

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The various GDS removal messages use goal level rather than name number when 
printing the state that was removed:

SNPRINTF( buf, 254, "remove_module_wme: Removing state S%d because element in 
GDS changed.", w->gds->goal->id.level );

Ideally this would use Soar's built-in symbol formatting rather than 
constructing it manually.

It looks like the messages are correct in decide.cpp.

Original issue reported on code.google.com by dave...@gmail.com on 11 Jun 2010 at 12:00

GoogleCodeExporter commented 8 years ago
I rolled the debugging message in to gds_invalid_so_remove_goal and changed it 
to use the built-in symbol formatting. Checking in after testing.

Original comment by voigtjr@gmail.com on 16 Jun 2010 at 3:19

GoogleCodeExporter commented 8 years ago
From commit message 12043:

Issue 75: Incorrect GDS removal messages.

 * Pushed removal message in to gds_invalid_so_remove_goal
 * Created new print routines to clean this message creation up: 
   * snprintf_with_symbols: like print_with_symbols except prints to buffer instead of calling print_string
   * vsnprintf_with_symbols: shared code between print_with_symbols and snprintf_with_symbols that takes va_list instead of variable number of args
 * Cleaned up add_wme_to_gds message creation

Original comment by voigtjr@gmail.com on 16 Jun 2010 at 3:45