search

sleyzerzon / soar

Automatically exported from code.google.com/p/soar
1 stars 0 forks source link

Lots of duplicate code in sml_KernelHelpers.cpp #77

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This may be a remnant of gSKI, but there's a bunch of code there that looks 
copy/pasted from the core kernel code. All the "explain backtraces"-related 
code looks copied from explain.cpp. There's probably more.

Original issue reported on code.google.com by dave...@gmail.com on 12 Jun 2010 at 12:55

GoogleCodeExporter commented 8 years ago

Original comment by voigtjr@gmail.com on 15 Jun 2010 at 5:00

GoogleCodeExporter commented 8 years ago 
 * Duplicate code removed: some code modified so that it could use kernel versions instead of custom duplicated code (such as symbolToString, etc)
 * KernelHelpers class removed -- all code moved closer to the commands where it is actually used. Most of KernelHelpers was command implementations. This stems from the gSKI Evil Back Door, it was the only place kernel calls could be made back when gSKI was around. The commands can make the kernel calls now themselves.
 * The code in the command files could be cleaned up a bit now that this layer is removed.

Original comment by voigtjr@gmail.com on 15 Jun 2010 at 9:21