search

slgobinath / SafeEyes

Protect your eyes from eye strain using this simple and beautiful, yet extensible break reminder
http://slgobinath.github.io/SafeEyes/
GNU General Public License v3.0
1.45k stars 163 forks source link

Change the order of the indicator implementations fallback #502

Closed pacho2 closed 2 months ago

pacho2 commented 1 year ago

Currently trayicon plugin will try to load old libappindicator implementation and, if not found, fallback to the new one:

    gi.require_version('AppIndicator3', '0.1')
    from gi.repository import AppIndicator3 as appindicator
except:
    #fall back to Ayatana
    gi.require_version('AyatanaAppIndicator3', '0.1')
    from gi.repository import AyatanaAppIndicator3 as appindicator

the problem is that, during the transition, it is common to have both installed (as they can be installed at the same time) and, then, it will keep using the old (unmaintained) version over the new one.

I would then reverse the logic to fallback to the old implementation if ayatana one is not present

Thanks a lot

AdamPS commented 9 months ago

Great it seems that you know what the fix is. If you could create a pull request and test it works for you then we can merge it.

archisman-panigrahi commented 2 months ago

@deltragon Is this still relevant? I guess now we are only using org.kde.StatusNotifierItem

deltragon commented 2 months ago

Yeah, this has been fixed by #558.