search

slgobinath / SafeEyes

Protect your eyes from eye strain using this simple and beautiful, yet extensible break reminder
http://slgobinath.github.io/SafeEyes/
GNU General Public License v3.0
1.41k stars 159 forks source link

New release with Python 3.12 support? #552

Closed hartwork closed 1 week ago

hartwork commented 6 months ago

Hi!

@slgobinath pull request #544 fixed support for Python 3.12 but there is no new release so that Linux distros will need to cherry-pick commits and add them as patches downstream if there is no new release. That's a bit unfortunate. Is there a chance you could cut a new release from master?

Best, Sebastian

AdamPS commented 6 months ago

Yes I am aware of the benefits of creating a release😃. slgobinath is mostly away, he made me a co-maintainer, but I only have a little time. We are aiming to keep this project alive however please be patient.

AdamPS commented 6 months ago

(Closing as it's not a bug😃)

hartwork commented 6 months ago

@AdamPS I don't see how it's helping to close this without a release, but I accept your decision.

AdamPS commented 6 months ago

OK how about like this?

AdamPS commented 5 months ago

Proposed steps:

  1. Check for any other issues that are a priority and easy to fix. I've just spotted there are 15 open pull requests, mostly fairly recent. Anyone can get involved by reviewing and testing these. Once they are confirmed as ready by a second person then please post a comment here linking the issue, and we can merge.
  2. Update any translations?
  3. Follow the how to release process.
archisman-panigrahi commented 3 months ago

Safeeyes is broken on Ubuntu 24.04 due to this issue. Given that this is a critical bug on recently released distros, can you please make a new version?

The pull requests can be reviewed one by one later.

archisman-panigrahi commented 3 months ago

@AdamPS I can send a pull request with steps 1-5 as described here https://github.com/slgobinath/SafeEyes?tab=readme-ov-file#how-to-release Please let me know if that would make the job easy for you, since you are busy.

deltragon commented 3 months ago

I agree that it would make sense to make a release that is just 2.1.6 plus the python 3.12 fix, and to take care of the current changes on master/open PRs after that.

vijay-prema commented 2 months ago

I noted the flatpak version is still the old 2.1.6 release but works fine on Ubuntu 2404, because I guess it is a standalone container.

You can get it from Flathub, and use it until a new release is made in the ppa that supports Python 3.12. Copy the ~/.config/safeeyes/safeeyes.json file to ~/.var/app/io.github.slgobinath.SafeEyes/config/safeeyes/safeeyes.json to retain your settings.

archisman-panigrahi commented 2 months ago

Can we just have a new release with whatever commit there is in the master branch?

archisman-panigrahi commented 2 months ago

I created a pull request (with current master branch + updated version number) to speed up the release process https://github.com/slgobinath/SafeEyes/pull/572

Please note that we need safeeyes to function out of the box in Ubuntu and Fedora. Translations can wait.

Nefcanto commented 1 month ago

It's unfortunate that even with the help of the community the release is not provided.

archisman-panigrahi commented 1 month ago

@AdamPS @slgobinath

I will be happy to be a co-maintainer on GitHub for managing releases (I am not a proficient python programmer, and may not be able to wrok on new features), and I can also maintain the PPA. (for credibility: Here is the list of PPAs I maintain https://launchpad.net/~apandada1)

slgobinath commented 2 weeks ago

Thanks @archisman-panigrahi for stepping in. I'm no longer able to maintain the Ubuntu PPA. Appreciate it if you could maintain it. Is there a way to give access to you for the existing launchpad? If not feel free to create your own repo and abandon the old one.

slgobinath commented 2 weeks ago

2.1.7 is released

hartwork commented 2 weeks ago

@slgobinath thanks!

One of the two tags für 2.1.7 seems mistaken — could you delete vv2.1.7 with double v?

tags_Screenshot_20240608_224751

slgobinath commented 2 weeks ago

Done

hartwork commented 2 weeks ago

@slgobinath thanks!

It turns out that the double vv tag did have the right content and the single v does not: it is missing #577. My vote for re-releasing as 2.1.8, since packaging tag 2.1.7 in distros now would package something incomplete (and moving tags is evil). What do you think? Which commit does PyPI 2.1.7 match?

slgobinath commented 2 weeks ago

Sure I'm stepping out. I'll do another release later today.

hartwork commented 2 weeks ago

Sure I'm stepping out.

@slgobinath I'm not 100% what you refer to here. Could you elaborate?

I'll do another release later today.

Thank you! Please see #578 in case you want to release via a push to branch release.

slgobinath commented 2 weeks ago

@hartwork thanks for your PR. Released 2.1.8

hartwork commented 2 weeks ago

@slgobinath thank you!

I have bumped to 2.1.8 in Gentoo just now.

Unfortunately, there is a regression in 2.1.7/2.1.8: #580.

archisman-panigrahi commented 2 weeks ago

Thanks @archisman-panigrahi for stepping in. I'm no longer able to maintain the Ubuntu PPA. Appreciate it if you could maintain it. Is there a way to give access to you for the existing launchpad? If not feel free to create your own repo and abandon the old one.

There is no way I can access the existing Launchpad PPA.

Here is the new PPA https://launchpad.net/~safeeyes-team/+archive/ubuntu/safeeyes

I designed it in a way that it is owned by "Safe Eyes" team rather than me, so that in case I have to step down at some point (I promise that it is not happening anytime soon), someone can easily pick it up without needing to create a new PPA. And it is very easy to add/remove members to the team in Launchpad. The current members of the team are me and @slgobinath.

I will send a PR with the new PPA link in the README and the website.

For now I only added support for Ubuntu 24.04 and later versions in the PPA (this may change later), because these versions of Ubuntu did not have a working safe eyes version, and older versions of Ubuntu had a working version of safe eyes, and I don't want to introduce regression.

archisman-panigrahi commented 2 weeks ago

I guess we can close this issue.

archisman-panigrahi commented 2 weeks ago

@slgobinath Can you please edit the description of the old PPA, and add the link to the new PPA, and rename the old PPA to "Safe Eyes (discontinued)"?

Nefcanto commented 2 weeks ago

@archisman-panigrahi, thank you so much. I worked.

slgobinath commented 2 weeks ago

Updated the old PPA https://launchpad.net/~slgobinath/+archive/ubuntu/safeeyes

Also updated the README and SafeEyes website

archisman-panigrahi commented 1 week ago

Please close this issue. Most of the major distros (Ubuntu,Fedora,Arch) already have the updated version with python3.12 support.

Nefcanto commented 1 week ago

@archisman-panigrahi, does this mean that we don't need this code anymore?

    sudo add-apt-repository ppa:safeeyes-team/safeeyes -y
    sudo apt-get update
    sudo apt-get install safeeyes -y

And we can simply run sudo apt install safeeyes -y to install it?

archisman-panigrahi commented 1 week ago

@Nefcanto No, the PPA is required in Ubuntu 24.04, as Ubuntu (usually) does not update its software during the lifetime of a release. But it should not be required in later versions of Ubuntu, because eventually the Debian developers will package the new version and it will flow down to Ubuntu.

Update: Ubuntu 24.10 already got safeeyes 2.1.9 in its official repositories. https://packages.ubuntu.com/oracular/safeeyes Same for Debian Sid.