slgobinath / SafeEyes

Protect your eyes from eye strain using this simple and beautiful, yet extensible break reminder
http://slgobinath.github.io/SafeEyes/
GNU General Public License v3.0
1.41k stars 159 forks source link

trayicon: migrate from libappindicator to org.kde.StatusNotifierItem #558

Open deltragon opened 6 months ago

deltragon commented 6 months ago

This is necessary for migrating to gtk4, as gtk4 does not support libappindicator (neither the gtk nor ayatana version, see https://github.com/AyatanaIndicators/libayatana-appindicator/issues/22).

The org.kde.StatusNotifierItem is non-standard, however it seems more likely to be a way forward than libappindicator. See also https://pagure.io/fedora-workstation/issue/246 for a discussion on this. For example, this should also work on default ubuntu desktop installs, with GNOME using https://github.com/ubuntu/gnome-shell-extension-appindicator.

Unfortunately, since it is not standardized yet, there is no python library for using it, so this PR needs to create its own bespoke implementation of the DBus interactions. Additionally, this also drops dbus-python in favor of Gio's dbus.

This is tested in KDE Plasma 5.27.