search

slgobinath / SafeEyes

Protect your eyes from eye strain using this simple and beautiful, yet extensible break reminder
http://slgobinath.github.io/SafeEyes/
GNU General Public License v3.0
1.41k stars 159 forks source link

Please update translation files to Weblate #569

Closed embar- closed 2 days ago

embar- commented 3 months ago

Describe the bug Translation strings in Weblate are outdated. E.g. Lithuanian strings in Weblate are fully translated, but some strings in SafeEyes is still in English - these can not be translated in Weblate. E.g. One of recents changes introduced sub-menu option to select type of break to do prior automatic time https://github.com/slgobinath/SafeEyes/commit/9e64e65fcec23da372d5b7d9dea60a16442842c6; however these changes did not resulted into updated localisation files.

To Reproduce Steps to reproduce the behavior:

  1. In fully translated non-English SafeEyes 2.1.6 (e.g. with Lithuanian language), open systray icon
  2. Click on option to make break now
  3. See error options in English

paveikslas

Expected behavior See options in Lithuanian; at least see not-translated strings in Weblate.

Desktop (please complete the following information):

Debug Log Run the Safe Eyes using safeeyes --debug command attach the ~/safeeyes.log` file.

Screenshots If applicable, add screenshots to help explain your problem.

archisman-panigrahi commented 2 days ago

@slgobinath Can you please look into this?

deltragon commented 2 days ago

@embar- Could you suggest a Lithuanian translation for the missing strings? I can add them, but I do not speak Lithuanian.

slgobinath commented 2 days ago

The problem was not me running update-po.sh after modifying the pot file. I've run it and pushed the changes to master. Also updated the weblate with the changes. Now these strings are available to translate at https://hosted.weblate.org/translate/safe-eyes/-/lt/?q=state:%3Ctranslated

slgobinath commented 2 days ago

Thanks, @archisman-panigrahi for tagging me. I will leave it to your decision on when to close this issue. Safe Eyes side is fixed. We can either close it as done or wait until someone translates the Lithuanian.

archisman-panigrahi commented 2 days ago

Alright. I did not know about update-po.sh. I will add running update-po.sh to the release checklist, so that we don't forget to periodically run it.

I am closing this issue since all we could do has been done.

@embar- Please update the Lithuanian translations in weblate.

archisman-panigrahi commented 2 days ago

@slgobinath How are we supposed to update https://github.com/slgobinath/SafeEyes/blob/master/safeeyes/config/locale/safeeyes.pot? Do we have to manually update it after adding something new to safeeyes, or is there a script to automatically do that as well?

slgobinath commented 2 days ago

As of now, the https://github.com/slgobinath/SafeEyes/blob/master/safeeyes/config/locale/safeeyes.pot should be updated manually if we're adding any new strings.

After the pot file is updated, the https://github.com/slgobinath/SafeEyes/blob/master/update-po.sh script must be executed to update all .po files