search

slgobinath / uget-chrome-wrapper

Moved to https://github.com/ugetdm/uget-integrator and https://github.com/ugetdm/uget-extension
GNU General Public License v3.0
75 stars 14 forks source link

Let user to define the minimum size to ignore including 0 #17

Closed ghostBot closed 7 years ago

ghostBot commented 7 years ago

Extension don't work on links like that: Icons for uget I'm using uget-2.0.9, uget-chrome-wrapper-2.0.2, uGet Integration 2.0.3, python 3.4.5 on linux system

slgobinath commented 7 years ago

The above file size is < 300 kb which uGet Integration extension does not care about. (See backgroung.js)

This condition is added to avoid the extra effort to download small files. Based on my opinion, tiny files do not require resume capability and/or multi-thread download acceleration. If you feel this condition is not necessary, please do let me know with your side reasons.

ghostBot commented 7 years ago

I understand your point of view. It's not error and can live with it.

How about torrent files? They are always small, and i didn't seen torrent file more then 300kb. Also some forums\trackers get you link which passes this condition, but files smaller then 300kb. Maybe in future releases extension can filter downloads with mime type or other options. It's possible?

slgobinath commented 7 years ago

+1 I will add UI support to define the minimum size.

ghostBot commented 7 years ago

Thank you, I will be waiting this.

slgobinath commented 7 years ago

Added with https://github.com/slgobinath/uget-chrome-wrapper/commit/26f8ad1a37503dc220450435f657782a945473de. Will be included in the next release.