search

slgobinath / uget-chrome-wrapper

Moved to https://github.com/ugetdm/uget-integrator and https://github.com/ugetdm/uget-extension
GNU General Public License v3.0
75 stars 14 forks source link

Garbled filenames #35

Closed gyratory closed 6 years ago

gyratory commented 6 years ago

Firefox Version: Nightly
Distro: Ubuntu 17.10
uGet settings: quiet mode enabled for command line, using aria2 as the plugin

Hi, thank you for the work on integrating uGet with Firefox! This is a pretty good replacement for DownThemAll.

The problem I'm encountering with the Firefox extension has two elements:

  1. Non-ASCII or any non-latin character filename becomes garbled, for example ♥♥♥ turns into ♥♥♥ or それ turns into それ
  2. Files with special characters (bangs, brackets, etc) in the name are downloaded as encoded URLs. e.g. Cute! [cats].jpg turns into Cute%21 %28cats%29.jpg

The first case (mojibake/tofu) is not replicated in Vivaldi but the second case with encoded URLs is. I haven't tried any of the other supported browsers.
Also, using the --content-disposition-default-utf8=true flag in the aria2 plugin settings doesn't seem to affect the downloads passed by Firefox at all.

slgobinath commented 6 years ago

The filename passed by the extension has nothing to do with the aria2 or uGet level settings. I will fix this soon.

slgobinath commented 6 years ago

Hi, Could you please check the new extension (2.1.0) and uget-chrome-wrapper (2.0.6) and see whether this problem persists? If it is still there, please send me the link which causes this problem so that I can test and find the solution.

Thanks

gyratory commented 6 years ago

I've updated the extension and wrapper to the latest versions and it works as expected now in Nightly.

Good stuff!