As a tool with extended options

slhck / ffmpeg-debug-qp

FFmpeg Debug Script for QP Values

Other

75 stars 24 forks source link

As a tool with extended options #13

Closed ndtreviv closed 4 years ago

ndtreviv commented 4 years ago

In this version:

Extracting the debug output and parsing it are combined into a single step
The functionality to extract and parse has been moved to a single python file, which could be imported by other project files
Additional macroblock information can be optionally extracted (being: interlaced, segmentation and type)
Output examples are included in the documentation
An example.py file has been created to show how it might be used

slhck commented 4 years ago

Thanks 🎉 I will test this soon. Sorry for not being too responsive these days.

I cannot merge this though, as the parse-qp-output.py file has conflicts. I think these need to be merged in your branch (with a merge commit), or you would have to rebase your changes on top of my master branch (since there was a bugfix committed recently: https://github.com/slhck/ffmpeg-debug-qp/commit/2804904691fd401ed5c955377042238ca36e0aaf).

Some small things that I think could be improved (but I can also do this later):

Rename example.py to something more meaningful
Move the examples to an examples directory

ndtreviv commented 4 years ago

I've fixed the conflicts, and made some changes to take into account the feedback.

Some small things that I think could be improved (but I can also do this later):

Rename example.py to something more meaningful

Move the examples to an examples directory

slhck commented 4 years ago

Thanks. I did a few more cleanups and fixed a few bugs, merged now.

Please note that I changed the "output" parameter to be mandatory (i.e. not as an option with leading double-dashes).