search

slhck / ffmpeg-normalize

Audio Normalization for Python/ffmpeg
MIT License
1.28k stars 118 forks source link

Minor improvements of language #192

Closed nkh0472 closed 2 years ago

slhck commented 2 years ago

Thanks for the PR!

I don't agree with most of these changes, as they are mostly superficial. In many places definitive articles have been left out for brevity. Some changes introduce other errors. Note that "FFmpeg" is a project, whereas "ffmpeg" is a command-line tool, and the choice of capitalization was made deliberately.

nkh0472 commented 2 years ago

Thanks for the PR!

I don't agree with most of these changes, as they are either superficial. In many places definitive articles have been left out for brevity. Some changes introduce other errors. Note that "FFmpeg" is a project, whereas "ffmpeg" is a command-line tool, and the choice of capitalization was made deliberately.

Learns a lot. Thanks for your patiently reply!

By the way, I find this package very helpful.

So, I'll try to contribute to this repo when I have some better idea :)

slhck commented 2 years ago

No problem! I understand you had good intentions and wanted to improve it.