slhck / ffmpeg-normalize

Audio Normalization for Python/ffmpeg
MIT License
1.25k stars 117 forks source link

Please consider using `static-ffmpeg` to eliminate `ffmpeg` explicit dependency #220

Closed zackees closed 1 year ago

zackees commented 1 year ago

https://github.com/zackees/static-ffmpeg pip install static-ffmpeg

import static_ffmpeg
static_ffmpeg.add_paths(weak=True)  # only installs if ffmpeg is not currently in path

This will eliminate an installation step and make the system work out of the box. static-ffmpeg works for Mac/Windows/Ubuntu

slhck commented 1 year ago

Thanks for the suggestion.

While I understand the purpose of your package, and I agree that “working out of the box” would be a nice feature, I am not comfortable with adding this kind of third-party dependency.

Some reasons and constructive feedback:

slhck commented 1 year ago

I updated the README to point users to places and methods to install ffmpeg.