search

slhck / ffmpeg-normalize

Audio Normalization for Python/ffmpeg
MIT License
1.28k stars 118 forks source link

fix capping to [1, 50] instead of [1, 7] #230

Closed mjhalwa closed 1 year ago

mjhalwa commented 1 year ago

One of the last commits introduced a capping of input_lra to [1, 7], but this has issues with songs having input_lra > 7 as setting a lower LRA than input_lra forces ffmpeg to Dynamic loudness correction. (I guess it was a mind-twist with the LRA=7.0 required for the EBU Standard.)

I hope it is ok that I directly created a PR, but as this breaks the --keep-loudness-range-target flag, I wanted to introduce a fix as soon as I saw and validated the issue.

If I am wrong, please just close the PR. In this case I am sorry for the hassle.

slhck commented 1 year ago

Oh, you're right. Will get to it tomorrow. Thanks for the PR!

mjhalwa commented 1 year ago

you're welcome, I'm glad to help out.

slhck commented 1 year ago

Released as v1.27.1