search

slhck / ffmpeg-progress-yield

Run an ffmpeg command with progress
MIT License
57 stars 6 forks source link

fix: the logic of the option --progress-only #24

Closed LaunchLee closed 3 weeks ago

LaunchLee commented 3 weeks ago

Sorry for making commit again so quickly.

I noticed the output would differ in Windows and *nix, so I changed the print to print escape sequence without newline in Windows. Moreover, the escape sequence will be printed certainly on Windows but it doesn't matter.

And I make the option influence the segment "print(ff.stderr)" only so that do not make more confusion. (The condition args.progress_only and platform.system() == "Windows" means that the option is only available in Windows.)

That is it.

slhck commented 3 weeks ago

You are totally right, thank you for being so attentive! (It's Monday morning and I apparently need more ☕ )

I'll make a new release.

LaunchLee commented 3 weeks ago

Thanks for your appreciation. Have a spiritual day!