feat(ffprobe): FEAT-0001 get file duration by ffprobe

slhck / ffmpeg-progress-yield

Run an ffmpeg command with progress

MIT License

57 stars 6 forks source link

feat(ffprobe): FEAT-0001 get file duration by ffprobe #8

Closed kskadart closed 1 year ago

kskadart commented 1 year ago

hello @slhck Thank you for your work. I just wan to a bit improve the progress tool.

The main reason to get duration by FFprobe is the FFmpeg error log level. If the ffmpeg log level sets to error so stdout and sdterror pipes will catch only processing output without the info banner.

P.S to be honest it's my first MR please say if something wrong

slhck commented 1 year ago

Thanks for the pull request and helping make this library better.

Some feedback for future PRs:

It would be better for pull requests to only cover small, atomic changes, not multiple changes mixed into one commit.
I see you've made a lot of improvements to the overall handling. Your PR message should ideally motivate those additional changes. (I had to go look at the code to understand what else you changed.)

I will probably merge this with a few added changes.

slhck commented 1 year ago

Merged with smaller changes to fix the types (mypy) and formatting (black).

kskadart commented 1 year ago

Wow, great. To be honest I started from tests to understand how it should works and it was broken, I spend some time to understand your flow and tried to follow by it. After, I started implement the idea to use ffprobe

BTW, thank you very much for your feedback and your time @slhck