search

slic3r / Slic3r

Open Source toolpath generator for 3D printers
https://slic3r.org/
GNU Affero General Public License v3.0
3.34k stars 1.3k forks source link

File from Thingiverse makes Slic3r 1.3.0-dev crash all the time #4253

Open ilikegreen opened 6 years ago

ilikegreen commented 6 years ago

Version

Current 1.3.0-dev

Operating system type + version

Linux (based on current Ubuntu LTS, also tried the Windows version)

Behavior

STL/Config (.ZIP) where problem occurs

https://www.thingiverse.com/thing:1806407

lordofhyphens commented 6 years ago

Give it a pass through service.netfabb.com first.

Any model on thingiverse is garbage until proven otherwise.

ilikegreen commented 6 years ago

But a program shouldn't just die with an error like *** Error in./perl-local': realloc(): invalid next size: 0x00000000064c5fc0 ***` because of a bad input. This is a potential security flaw. It wouldn't be a problem if just a message occurred that this file coulnd't been opened or if the rendering or slicing wouldn't work, but that's something different.

The file works with outdated Slic3r versions and other slicer software btw.

lordofhyphens commented 6 years ago

Admesh is the underlying library used for input since 1.2.x. Replacing it has been on my wish list for quite some time, but when someone is working on this program in their spare time, crashes caused by garbage input (and such have a quick workaround) are low on the priority list.

Also STL is a terrible file format.

lordofhyphens commented 6 years ago

I will happily accept a pull request with a fix.

lordofhyphens commented 6 years ago

By the way, cova119_bottom_logo.stl didn't crash on my dev system when run in CLI mode. So it's the OpenGL preview.