slic3r / Slic3r

Open Source toolpath generator for 3D printers
https://slic3r.org/
GNU Affero General Public License v3.0
3.33k stars 1.3k forks source link

Port and generalize PrusaEdition GCodeTimeEstimator #4371

Open lordofhyphens opened 6 years ago

lordofhyphens commented 6 years ago

The fine people over at @prusa3d wrote a tuned estimator for the Prusa i3 MK2/3 for their fork of Slic3r.

Looking it over, it appears as such that it would not be difficult to port it back to upstream Slic3r, either as an option (along with some extensions to the current Estimator) or as a replacement to the main Estimator.

However, @bubnikv and crew were able to make some general assumptions in their own firmware config (as they control it) for Slic3rPE, which we shouldn't do here.

A port of the Estimator should have the following additions:

bubnikv commented 6 years ago

Support for more GCode syntaxes. Currently just the RepRap/Marlin (or specifically what Prusa3D uses) is expected. These additional gcode syntaxes should use the GCode flavor.

This is not quite correct. The time estimator tries to decode the GRBL kinematics values from the G-code based on the active G-code flavor. It should therefore work for other firmware flavors as well. It has to be tested though.

You are right that a dialog for entering these values would be nice. However you will have a chance of discrepancy between what the firmware thinks vs. what Slic3r simulates. Therefore if you create a config page for the GRBL based speed / acceleration / jerk limits, you will then have to insert them into the G-code as well.