slic3r / Slic3r

Open Source toolpath generator for 3D printers
https://slic3r.org/
GNU Affero General Public License v3.0
3.33k stars 1.3k forks source link

Wide empty infill with concentric infill #4560

Open Liger0 opened 6 years ago

Liger0 commented 6 years ago

Version

1.3.1-dev

Operating system type + version

Windows 10

Behavior

Using concentric top and bottom layer infill, except for precise models done just considering everything like the line width, flow and so on (at least I guess), there will be widely empty parts on the top and bottom surfaces.

walls slic3r

supermerill commented 6 years ago

I also have this. I wonder if we should add gapfill lines to it ...

I can do that, it's easy but i need some input from other users on their opinions.

Liger0 commented 6 years ago

I also have this. I wonder if we should add gapfill lines to it ...

I can do that, it's easy but i need some input from other users on their opinions.

It is important to say it is pretty much the same even using the rectilinear infill. I see the option to fill the gaps already is implemented with the rectilinear infill (after exporting to gcode I see the gap infill type of line somewhere), but it really works bad, filling only a minimum amount of gaps and leaving about the 90%, especially the big ones. About the perimeters gaps, on the other side, take a look at what happens everytime at the start and end point of each line. It is visible and really makes an horrible effect on the print. wall corruption 2

supermerill commented 6 years ago

I see the option to fill the gaps [...], but it really works bad, filling only a minimum amount of gaps and leaving about the 90%, especially the big ones.

hopefully my rework of thin wall will improve that as well.

look at what happens everytime at the start and end point of each line

I don't understand. can you show me a layer where the outer perimeter is bad? If you talk about the seam, there's nothing to do but to try to hide it in a corner.

Liger0 commented 6 years ago

I see the option to fill the gaps [...], but it really works bad, filling only a minimum amount of gaps and leaving about the 90%, especially the big ones.

hopefully my rework of thin wall will improve that as well.

look at what happens everytime at the start and end point of each line

I don't understand. can you show me a layer where the outer perimeter is bad? If you talk about the seam, there's nothing to do but to try to hide it in a corner.

Isn't it possible to just continue the run more? Because it really doesn't touch the starting point. Also the seam options don't work, whatever I set they will always be in the same positions as in the image.

supermerill commented 6 years ago

Somebody should merge this pr https://github.com/prusa3d/Slic3r/pull/728 then.

But it's an other issue, not this one. You should create a new one or search if it doesn't exist.

back to the topic "Wide empty infill with concentric infill"

supermerill commented 5 years ago

Done

concentric_gapfill

but the amount of tiny fills can easily ruin a top surface: the gcode generator doesn't do a stellar job to order them (but it's at "good enough" level imo). Should i force them to be lay down after the circles? should i create a new infill (concentric+gapfill)?

Liger0 commented 5 years ago

What about only making it on the non-latest layers? So there won't be holes but still the externall skin won't be ruined. Also if ironing will be implemented it will be able to fill the skin gap too without ruining the face.

supermerill commented 5 years ago

Also if ironing will be implemented it will be able to fill the skin gap too without ruining the face.

I tried that. Not better than rectilinear. Maybe worth a second try, it's easy to do.

Liger0 commented 5 years ago

Also if ironing will be implemented it will be able to fill the skin gap too without ruining the face.

I tried that. Not better than rectilinear. Maybe worth a second try, it's easy to do.

Or you can chose if to fill gaps normally like we said previously on the top surface too. Even if it will be messed, you can fix it ironing without extruding.

supermerill commented 5 years ago

you can fix it ironing without extruding.

i extrude with ironing, even cura extrude. these gaps are too wide to be filled by an ironing, anyway.

supermerill commented 5 years ago

commit for fix: supermerill/Slic3r@60442ba may submit a pr when i have time. Note that it uses some code i added with the ironing infill (making the no_sort parameter working), so I have to wait the merge, anyway.

supermerill commented 3 years ago

I'm not sure it's that desirable image

Liger0 commented 3 years ago

I'm not sure it's that desirable image

They are rewriting that gap filling for cura 4.9, you may take a look at their arachne implementation.